Use ghrc.io/datadog/images-rb as base - Githubissues

DataDog / dd-trace-rb

Datadog Tracing Ruby Client

https://docs.datadoghq.com/tracing/

Other

304 stars 373 forks source link

Use ghrc.io/datadog/images-rb as base #3737

Open lloeki opened 3 months ago

lloeki commented 3 months ago

What does this PR do?

Start using images from ghrc.io/datadog/images-rb

Motivation:

Centralise image management across Ruby repositories
Decouple image generation from this repository, which causes conundrums such as in this very PR: to make use of the new images this PR must be merged without actually making use of the images in the actual CI, then a public workflow to publish the images must be triggered, and finally a second PR must be opened to actually make use of the new images.

Additional Notes:

Part of the CI being in CircleCI makes it annoying: I can't even hack something where the image build would happen and CircleCI would use those.
The integration tests are especially annoying as well, with some additional docker-compose stuff inside Docker.

How to test the change?

Hard.