search

DataDog / dd-trace-rb

Datadog Tracing Ruby Client
https://docs.datadoghq.com/tracing/
Other
299 stars 368 forks source link

DEBUG-2507 Test individual product loading #3738

Closed p-datadog closed 5 days ago

p-datadog commented 1 week ago

Replacement for https://github.com/DataDog/dd-trace-rb/pull/3646.

This PR tests that each product can be loaded by itself, and repairs appsec to be loadable without tracing having already been loaded.

The tests are redone to use system rather than forking and no longer require a separate job.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.10%. Comparing base (154f72e) to head (d4189c3). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3738 +/- ## ========================================== - Coverage 98.10% 98.10% -0.01% ========================================== Files 1227 1228 +1 Lines 73014 73027 +13 Branches 3508 3508 ========================================== + Hits 71633 71645 +12 - Misses 1381 1382 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

p-datadog commented 6 days ago

@TonyCTHsu

The tests are redone to use system rather than forking and no longer require a separate job.

p-datadog commented 6 days ago

Also the PR is a new one because the branch is in the main repo, not in a fork for CI reasons.

p-datadog commented 5 days ago

@TonyCTHsu I added comments for the appsec changes, if there is a different solution that would also be fine with me.