DataDog / dd-trace-rb

Datadog Tracing Ruby Client
https://docs.datadoghq.com/tracing/
Other
304 stars 372 forks source link

Datadog::Tracing.correlation without trace information #3773

Open c2ofh opened 2 months ago

c2ofh commented 2 months ago

Current behaviour Datadog::Tracing.correlation output does not include trace_information

Expected behaviour Information about trace_name, trace_resource, trace_service

Steps to reproduce Use ddtrace gem. There the information is included.
Now we switched to datadog gem as it's needed for using profiling.

How does datadog help you? To extend our log by helpful information to support customers

Environment

TonyCTHsu commented 2 months ago

👋 @c2ofh , Thanks for reaching out. There are fields being removed from Correlation::Identifier in 2.x , https://github.com/DataDog/dd-trace-rb/blob/master/docs/UpgradeGuide2.md#log-correlation .

Information about trace_name, trace_resource, trace_service

Those fields were not part of our public API, hence they are not tested, documented and subject to changes. My understanding is that Correlation::Identifier#service is still available and should return the same result for trace_service (trace_name, trace_resource are removed)

Could you provide an example about how you add custom information into your logs? What does the log looks like before & after.