search

DataDog / dd-trace-rb

Datadog Tracing Ruby Client
https://docs.datadoghq.com/tracing/
Other
311 stars 375 forks source link

Option to Disable Storing Cache Keys in Span Traces #4017

Open n-ikhil opened 1 month ago

n-ikhil commented 1 month ago

In our Rails application, we've observed that cache keys are being recorded and displayed in span traces within the Datadog UI. This behavior raises potential security and privacy concerns, as cache keys may contain sensitive or identifiable data. Additionally, showing the cache keys in the UI can clutter trace details, making it harder to focus on high-level performance insights.

We would like to request a feature that allows users to disable the storage of cache keys in span traces, either by:

  1. Configuration option: Introduce a flag to enable/disable the recording of cache keys.
  2. Redaction: Provide an option to redact or anonymize cache keys before they are displayed.
delner commented 1 month ago

Thanks for raising this! I assume this is for ActiveSupport? Or for a different framework/client?

I will forward this to our team, see what they think of it. We do provide similar capabilities to quantize other fields such as HTTP headers and what not, so its not unprecedented.

n-ikhil commented 1 month ago

Yes @delner this is for ActiveSupport integration.

delner commented 1 month ago

Hi @n-ikhil , just wanted to update you: we've opened #4022 to add the capability to disable the collection of cache keys. The PR does not include any kind of redaction option yet.

n-ikhil commented 5 days ago

@delner any update with the pr/rollout ?