DataDog / expo-datadog

Datadog SDK for Expo
Apache License 2.0
8 stars 5 forks source link

Dsyms upload ignores configuration #3

Closed Nicktho closed 5 months ago

Nicktho commented 2 years ago

Describe what happened Setting configuration to the following:

{
    "expo": {
        "plugins": [
            [
                "expo-datadog",
                {
                    "errorTracking": {
                        "iosDsyms": false
                    }
                }
            ]
        ]
    }
}

Still results in dsyms being uploaded to datadog when running expo run:ios to build the ios application.

Steps to reproduce the issue:

Describe what you expected: Dsyms not uploaded to datadog

Additional context

louiszawadzki commented 1 year ago

Hi @Nicktho, thanks for reaching out and apologies for the delay.

One possible explanation for your issue: when the iOS app is built, we upload 2 mapping files:

If you only disable dsyms, you will still attempt to upload the javascript sourcemaps. To disable all uploads in iOS builds you should use:

{
    "expo": {
        "plugins": [
            [
                "expo-datadog",
                {
                    "errorTracking": {
                        "iosDsyms": false,
                        "iosSourcemaps": false
                    }
                }
            ]
        ]
    }
}

If you are still experiencing the issue, could you upload your iOS log to help us troubleshoot?

Thanks a lot!