DataDog / expo-datadog

Datadog SDK for Expo
Apache License 2.0
8 stars 5 forks source link

fix(#17): Monorepo sourcemap support #32

Closed honerlaw closed 5 months ago

honerlaw commented 7 months ago

What does this PR do?

Motivation

I was using the recommended approach from issue 17 of using patch-package, and would prefer not to.

Additional Notes

N/A

Review checklist (to be filled by reviewers)

Other

I am open to a different approach for handling this scenario.

marco-saia-datadog commented 7 months ago

Hi @honerlaw, thank you very much for your contribution! It looks really good at first glance, we will reach out soon with a proper review and perform some internal testing as well.

honerlaw commented 7 months ago

Hey @marco-saia-datadog I would say hold off on further testing at the moment, I have run into a few issues that need to be resolved first after further testing.

marco-saia-datadog commented 7 months ago

Hey @honerlaw! Thank you for the update, feel free to reach out at any moment

marco-saia-datadog commented 5 months ago

Hi @honerlaw!

We have decided to follow another approach, you can check it out in this PR: https://github.com/DataDog/expo-datadog/pull/38.

Thank you again for your time and your great contribution 🙏