search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Fix eds check threshold calculation #102

Closed ahmed-mez closed 3 years ago

ahmed-mez commented 3 years ago

What does this PR do?

looks like a bug in calculating the threshold based on pct

Motivation

o.nodeCompletionPct is lower than 1 and equals 0.95 by default

codecov-commenter commented 3 years ago

Codecov Report

Merging #102 (89206d0) into main (8eb4dbb) will increase coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   51.24%   51.33%   +0.09%     
==========================================
  Files          39       39              
  Lines        2096     2096              
==========================================
+ Hits         1074     1076       +2     
+ Misses        938      937       -1     
+ Partials       84       83       -1
Flag Coverage Δ
unittests 51.33% <ø> (+0.09%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/extendeddaemonsetreplicaset/controller.go 56.06% <0.00%> (+0.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8eb4dbb...89206d0. Read the comment docs.