fix: avoid empty reason when auto-pausing canary

[ahmed-mez]

What does this PR do?

• Make sure we don't return empty reasons in HighestRestartCount and MostRecentRestart
• Add new errors to the cannotStartReasons set:
  • ImageInspectError
  • ErrImageNeverPull
  • RegistryUnavailable
  • InvalidImageName
  • PreCreateHookError

Motivation

Make the canary auto-pause more reliable

Describe your test plan

InvalidImageName is the easiest option to reproduce:

• Deploy a valid eds with canary auto-pause enabled.
• Update the workload image name to an invalid value (include non alpha-numerical characters).
• Make sure the new canary is paused with the correct reason printed

  NAMESPACE  NAME              DESIRED  CURRENT  READY  UP-TO-DATE  AVAILABLE  IGNORED UNRESPONSIVE NODES  STATUS         REASON            ACTIVE RS               CANARY RS               AGE
  default    pause-containers  4        4        2      2           2          0                           Canary Paused  InvalidImageName  pause-containers-sz5ft  pause-containers-2qdx6  16 minutes

[codecov-commenter]

Codecov Report

Merging #133 (02379c6) into main (97329e9) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   62.28%   62.31%   +0.03%     
==========================================
  Files          41       41              
  Lines        2166     2168       +2     
==========================================
+ Hits         1349     1351       +2     
  Misses        711      711              
  Partials      106      106              

Flag	Coverage Δ
unittests	62.31% <100.00%> (+0.03%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/v1alpha1/extendeddaemonset_types.go	100.00% <ø> (ø)
pkg/controller/utils/pod/pod.go	91.26% <100.00%> (+0.17%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97329e9...02379c6. Read the comment docs.