Closed celenechang closed 2 years ago
Merging #134 (110472f) into main (e08ae24) will increase coverage by
0.06%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 62.31% 62.37% +0.06%
==========================================
Files 41 41
Lines 2168 2169 +1
==========================================
+ Hits 1351 1353 +2
Misses 711 711
+ Partials 106 105 -1
Flag | Coverage Δ | |
---|---|---|
unittests | 62.37% <0.00%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/plugin/common/pods.go | 0.00% <0.00%> (ø) |
|
pkg/plugin/common/table.go | 0.00% <0.00%> (ø) |
|
pkg/plugin/common/utils.go | 60.00% <0.00%> (-2.50%) |
:arrow_down: |
...trollers/extendeddaemonsetreplicaset/controller.go | 56.06% <0.00%> (+0.83%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e08ae24...110472f. Read the comment docs.
What does this PR do?
Move
getDuration
function to common/utils.go AddAge
column tocanary pods
cmdMotivation
To be able to easily see uptime of canary pods
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Build the binary with
make kubectl-eds
Deploy a daemonset with a canary Runkubectl eds canary pods <ds name>
and make sure theAge
makes sense