search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

[plugin] add age to canary pods cmd #134

Closed celenechang closed 2 years ago

celenechang commented 2 years ago

What does this PR do?

Move getDuration function to common/utils.go Add Age column to canary pods cmd

Motivation

To be able to easily see uptime of canary pods

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Build the binary with make kubectl-eds Deploy a daemonset with a canary Run kubectl eds canary pods <ds name> and make sure the Age makes sense

codecov-commenter commented 2 years ago

Codecov Report

Merging #134 (110472f) into main (e08ae24) will increase coverage by 0.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   62.31%   62.37%   +0.06%     
==========================================
  Files          41       41              
  Lines        2168     2169       +1     
==========================================
+ Hits         1351     1353       +2     
  Misses        711      711              
+ Partials      106      105       -1
Flag Coverage Δ
unittests 62.37% <0.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/plugin/common/pods.go 0.00% <0.00%> (ø)
pkg/plugin/common/table.go 0.00% <0.00%> (ø)
pkg/plugin/common/utils.go 60.00% <0.00%> (-2.50%) :arrow_down:
...trollers/extendeddaemonsetreplicaset/controller.go 56.06% <0.00%> (+0.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e08ae24...110472f. Read the comment docs.