search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

fix: enable profiling after logging setup #135

Closed ahmed-mez closed 2 years ago

ahmed-mez commented 2 years ago

What does this PR do?

Configure the logger before calling setupLog.

Motivation

This branch was logging before the logger was setup

    if ddProfilingEnabled {
        setupLog.Info("Starting datadog profiler")
...
    }

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Make sure this line Starting datadog profiler is logged correctly when profiling is enabled

codecov-commenter commented 2 years ago

Codecov Report

Merging #135 (8f77551) into main (f98add8) will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   62.37%   62.28%   -0.10%     
==========================================
  Files          41       41              
  Lines        2169     2169              
==========================================
- Hits         1353     1351       -2     
- Misses        711      712       +1     
- Partials      105      106       +1
Flag Coverage Δ
unittests 62.28% <ø> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/extendeddaemonsetreplicaset/controller.go 55.23% <0.00%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f98add8...8f77551. Read the comment docs.