search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Avoid adding new annotation if not needed #14

Closed clamoriniere closed 4 years ago

clamoriniere commented 4 years ago

avoid adding "MD5NodeExtendedDaemonSetAnnotationKey" annotation if the value is empty

codecov-io commented 4 years ago

Codecov Report

Merging #14 into master will decrease coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   34.78%   34.73%   -0.05%     
==========================================
  Files          22       22              
  Lines        1397     1399       +2     
==========================================
  Hits          486      486              
- Misses        848      850       +2     
  Partials       63       63
Flag Coverage Δ
#unittests 34.73% <0.00%> (-0.05%) :arrow_down:
Impacted Files Coverage Δ
...ller/extendeddaemonsetreplicaset/strategy/utils.go 17.64% <0.00%> (ø)
pkg/controller/utils/pod/create.go 26.92% <0.00%> (-1.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc702a7...4678879. Read the comment docs.