search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Upgrade Go, k8s.io/*, openapi definitions #147

Closed juliogreff closed 2 years ago

juliogreff commented 2 years ago

What does this PR do?

This is an attempt to solve a tricky dependency version puzzle in datadog-agent. Since that repo depends on this one (and datadog-operator, and watermarkpodautoscaler) for type definitions, they need to be using compatible openapi definitions. To get them, we also need to update k8s.io to a recent enough version (but not too recent! dependency issues). To be able to update k8s.io, we also need to upgrade to Go 1.17, since that's now required by controller-runtime.

Describe your test plan

This only upgrades dependencies, so no change in behavior is expected. Check that main functionality of the EDS still works.

codecov-commenter commented 2 years ago

Codecov Report

Merging #147 (8e8f1cb) into main (2043264) will decrease coverage by 0.13%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   63.35%   63.22%   -0.14%     
==========================================
  Files          41       41              
  Lines        3073     3073              
==========================================
- Hits         1947     1943       -4     
- Misses       1011     1014       +3     
- Partials      115      116       +1
Flag Coverage Δ
unittests 63.22% <ø> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/extendeddaemonsetreplicaset/controller.go 57.53% <0.00%> (-1.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2043264...8e8f1cb. Read the comment docs.