search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Add arm64 entries to eds plugin released file #152

Closed paulcacheux closed 2 years ago

paulcacheux commented 2 years ago

What does this PR do?

With https://github.com/DataDog/extendeddaemonset/releases/tag/v0.8.1-rc.1 we see that arm64 builds are now correctly generated but not included in eds-plugin.yaml.

This PR fixes this issue by including arm64 entries to this file. The darwin/arm64 being the most important in order to support M1/M2 macs.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

codecov-commenter commented 2 years ago

Codecov Report

Merging #152 (55f46ee) into main (4aee675) will increase coverage by 0.13%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   63.22%   63.35%   +0.13%     
==========================================
  Files          41       41              
  Lines        3073     3073              
==========================================
+ Hits         1943     1947       +4     
+ Misses       1014     1011       -3     
+ Partials      116      115       -1
Flag Coverage Δ
unittests 63.35% <ø> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/extendeddaemonsetreplicaset/controller.go 58.73% <0.00%> (+1.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4aee675...55f46ee. Read the comment docs.