Closed fanny-jiang closed 8 months ago
golangci-lint
Building the kubectl-eds plugin was broken in go v1.21
kubectl-eds
unparam
is always nil
updateInstanceWithCurrentRS
reconcile.Result{}
depguard
Write there any instructions and details you may have to test your PR.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (5d93a41) 63.10% compared to head (9226772) 63.10%.
5d93a41
9226772
What does this PR do?
golangci-lint
to v1.55.2 to support go v1.21Motivation
Building the
kubectl-eds
plugin was broken in go v1.21Additional Notes
unparam
linter to suppressis always nil
error from the EDS controller functionupdateInstanceWithCurrentRS
which returns a nilreconcile.Result{}
. Called here https://github.com/DataDog/extendeddaemonset/blob/b53e1cdba19da5b87ae2d6f90eeb6afe1764b7d7/controllers/extendeddaemonset/controller.go#L151depguard
linter to allow package importsDescribe your test plan
Write there any instructions and details you may have to test your PR.