DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Update golangci-lint to v1.55.2 #171

Closed fanny-jiang closed 8 months ago

fanny-jiang commented 9 months ago

What does this PR do?

Motivation

Building the kubectl-eds plugin was broken in go v1.21

Additional Notes

Describe your test plan

Write there any instructions and details you may have to test your PR.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5d93a41) 63.10% compared to head (9226772) 63.10%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171/graphs/tree.svg?width=650&height=150&src=pr&token=i8XjxcCWUi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## main #171 +/- ## ======================================= Coverage 63.10% 63.10% ======================================= Files 41 41 Lines 3098 3098 ======================================= Hits 1955 1955 Misses 1023 1023 Partials 120 120 ``` | [Flag](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `63.10% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [pkg/plugin/common/utils.go](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-cGtnL3BsdWdpbi9jb21tb24vdXRpbHMuZ28=) | `60.52% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [5d93a41...9226772](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/171?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).