search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

[CONTINT-3761] Use GBI for the internal eds-check image #175

Closed L3n41c closed 6 months ago

L3n41c commented 6 months ago

What does this PR do?

Migrate the internal extendeddaemonset-check image to GBI.

Motivation

Security folks want all containers running on our internal infra to be based on a GBI golden base image.

Additional Notes

See DataDog/images#5091. The idea is to use GBI for the internal image only and to keep UBI as today for the public one. As the binary is a standalone statically-linked file, it shouldn’t make any difference.

Describe your test plan

Update the version of extendeddaemonset-check in k8s-datadog-agent-ops and check that deployments are still working fine.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.10%. Comparing base (fcf8307) to head (2ed4beb).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175/graphs/tree.svg?width=650&height=150&src=pr&token=i8XjxcCWUi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## main #175 +/- ## ======================================= Coverage 63.10% 63.10% ======================================= Files 41 41 Lines 3098 3098 ======================================= Hits 1955 1955 Misses 1023 1023 Partials 120 120 ``` | [Flag](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `63.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [fcf8307...2ed4beb](https://app.codecov.io/gh/DataDog/extendeddaemonset/pull/175?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).