DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

feat: add EDSS ref on related Pod's labels #183

Closed clamoriniere closed 5 months ago

clamoriniere commented 5 months ago

What does this PR do?

Add 2 new labels on pods when they are linked to an ExtendedDaemonsetSettings resource.

Motivation

the goal is to allow pods filtering by ExtendedDaemonsetSettings name/ns.

Additional Notes

We use Labels and not annotations because we would like to be able to do pods query filtering like

kubectl get pod -l extendeddaemonsetsetting.datadoghq.com/name=foo -l extendeddaemonsetsetting.datadoghq.com/namespace=bar

Describe your test plan

Deploy an EDS and EDSS resource. on the pods linked to the EDSS the Pod labels should contains the 2 new labels.

clamoriniere commented 5 months ago

/merge

dd-devflow[bot] commented 5 months ago

:x: MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #devflow with those details!

clamoriniere commented 5 months ago

/merge

dd-devflow[bot] commented 5 months ago

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 5 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 5 months ago

:rotating_light: MergeQueue

mergequeue build completed successfully, but the github api returned an error while merging the pr. It's probably because:

Details Error: PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. [] FullStacktrace: activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-7bf8f9d97d-cbcdx@): PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

clamoriniere commented 5 months ago

/merge

dd-devflow[bot] commented 5 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 5 months ago

:x: MergeQueue

Tests failed on this commit e8164b2

You should fix those tests and then re-add your pull request to the queue!

Details some checks are failing: - [e2e (v1.16.9)](https://github.com/DataDog/extendeddaemonset/actions/runs/9030456704/job/24814765451)

If you need support, contact us on Slack #devflow with those details!

clamoriniere commented 5 months ago

/merge

dd-devflow[bot] commented 5 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 5 months ago

:rotating_light: MergeQueue

mergequeue build completed successfully, but the github api returned an error while merging the pr. It's probably because:

Details Error: PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. [] FullStacktrace: activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-6959cd9c66-pl5tx@): PUT https://api.github.com/repos/DataDog/extendeddaemonset/pulls/183/merge: 405 This branch must not contain merge commits. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!