search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Enable the possiblity to pause a Canary deployment #22

Closed juliogreff closed 4 years ago

juliogreff commented 4 years ago

In the ExtendedDaemonset.Spec.Strategy, it is possible to define a duration for the Canary deployment. At the end of this duration, if the ExtendedDaemonset was not rolled back, the Canary deployment becomes active and the rolling-update continues on all the nodes. By adding a Paused field, it's now possible to prevent that from happening until Paused is set back to false again. That's useful to investigate faulty deployments as they currently are, without the need for a full rollback.

Another way we could've implemented this would be with an annotation, but the last thing one needs when trying to prevent disaster is misspelling an annotation that's not validated, so I preferred to go with a new field.

codecov-commenter commented 4 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files          22       22           
  Lines        1406     1406           
=======================================
  Hits          490      490           
  Misses        853      853           
  Partials       63       63
Flag Coverage Δ
#unittests 34.85% <100.00%> (ø)
Impacted Files Coverage Δ
pkg/controller/extendeddaemonset/utils.go 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44fbeb8...88e64c1. Read the comment docs.