Closed clamoriniere closed 4 years ago
Merging #41 into master will increase coverage by
1.97%
. The diff coverage is86.66%
.
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 34.31% 36.29% +1.97%
==========================================
Files 24 25 +1
Lines 1658 1736 +78
==========================================
+ Hits 569 630 +61
- Misses 1013 1023 +10
- Partials 76 83 +7
Flag | Coverage Δ | |
---|---|---|
#unittests | 36.29% <86.66%> (+1.97%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
.../extendeddaemonset/extendeddaemonset_controller.go | 66.66% <ø> (+1.91%) |
:arrow_up: |
pkg/controller/utils/affinity/affinity.go | 59.18% <86.66%> (ø) |
|
.../controller/extendeddaemonsetreplicaset/filters.go | 78.21% <0.00%> (+4.78%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6acfa1a...4b8b12a. Read the comment docs.
selectNodes()
function that was using the Pod labelSelector to filter Nodes.Test plan:
examples/foo-eds_exclude-node.yaml
EDS in a test cluster.kubectl label node kind-worker extendeddaemonset.datadoghq.com/exclude=foo --overwrite
kubectl label node kind-worker extendeddaemonset.datadoghq.com/exclude- --overwrite
, the daemonset pod should be reschedule on the node.