DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Add pull request template #42

Closed clamoriniere closed 4 years ago

clamoriniere commented 4 years ago

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

codecov-commenter commented 4 years ago

Codecov Report

Merging #42 into master will decrease coverage by 1.46%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   35.19%   33.72%   -1.47%     
==========================================
  Files          25       25              
  Lines        1699     1515     -184     
==========================================
- Hits          598      511      -87     
+ Misses       1023      936      -87     
+ Partials       78       68      -10     
Flag Coverage Δ
#unittests 33.72% <ø> (-1.47%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/extendeddaemonsetsetting/utils.go 60.00% <0.00%> (-6.67%) :arrow_down:
pkg/controller/utils/labelselector.go 42.30% <0.00%> (-5.97%) :arrow_down:
pkg/controller/utils/labels.go 63.63% <0.00%> (-5.12%) :arrow_down:
...nsetsetting/extendeddaemonsetsetting_controller.go 20.33% <0.00%> (-3.20%) :arrow_down:
.../controller/extendeddaemonsetreplicaset/filters.go 70.37% <0.00%> (-3.07%) :arrow_down:
...endeddaemonsetreplicaset/strategy/limits/limits.go 66.66% <0.00%> (-2.57%) :arrow_down:
...ller/extendeddaemonsetreplicaset/strategy/utils.go 22.72% <0.00%> (-2.28%) :arrow_down:
...xtendeddaemonsetreplicaset/scheduler/predicates.go 12.24% <0.00%> (-1.67%) :arrow_down:
...onsetreplicaset/ddaemonsetreplicaset_controller.go 49.79% <0.00%> (-1.34%) :arrow_down:
pkg/controller/extendeddaemonset/utils.go 93.33% <0.00%> (-0.96%) :arrow_down:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6ee9f0...e6dd8eb. Read the comment docs.