DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Allow the EDS to deploy pods on unschedulable nodes #43

Closed L3n41c closed 4 years ago

L3n41c commented 4 years ago

What does this PR do?

Allow the ExtendedDaemonSet controller to deploy pods on unschedulable nodes.

Motivation

Have the same behaviour as with the regular Kubernetes DaemonSet. https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/#taints-and-tolerations

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Cordon a node and check that the EDS controller still deploy a pod on it.

codecov-commenter commented 4 years ago

Codecov Report

Merging #43 into master will increase coverage by 0.66%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   36.80%   37.46%   +0.66%     
==========================================
  Files          29       29              
  Lines        1508     1500       -8     
==========================================
+ Hits          555      562       +7     
+ Misses        879      865      -14     
+ Partials       74       73       -1     
Flag Coverage Δ
#unittests 37.46% <33.33%> (+0.66%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/extendeddaemonset/controller.go 68.93% <0.00%> (ø)
...xtendeddaemonsetreplicaset/scheduler/predicates.go 21.34% <ø> (+9.10%) :arrow_up:
pkg/controller/utils/pod/create.go 25.53% <0.00%> (-0.56%) :arrow_down:
controllers/extendeddaemonsetreplicaset/filters.go 70.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7eb5d61...f1b4b02. Read the comment docs.

vboulineau commented 4 years ago

We should be able to test this in E2E tests by building Nodes with custom taints.