Closed vboulineau closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
master@d72a1bc
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage ? 37.46%
=========================================
Files ? 29
Lines ? 1500
Branches ? 0
=========================================
Hits ? 562
Misses ? 865
Partials ? 73
Flag | Coverage Δ | |
---|---|---|
#unittests | 37.46% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d72a1bc...68bb282. Read the comment docs.
What does this PR do?
Add eds_controller_leader gauge to identify leader from
/metrics
and/ksmetrics
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Spawn two replicas of EDS instance, run
k exec -ti $POD -- curl http://localhost:8080/metrics
k exec -ti $POD -- curl http://localhost:8080/ksmetrics
You should see
eds_controller_leader
set to 1 withleader: true
orleader: false
if leader or follower.