search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Add canary paused / failed metrics #56

Closed xornivore closed 3 years ago

xornivore commented 3 years ago

What does this PR do?

Adds a new eds_status_canary_paused gauge metric to identify canary in paused state along with the reason. Adds a new eds_status_canary_failed gauge metric to identify canary in failed state along with the reason.

Motivation

Canary metrics

Describe your test plan

Check the metrics are exported correctly for canaries in active and paused state.

clamoriniere commented 3 years ago

Nice work 👍 Could you add also a metrics for failed status ?

celenechang commented 3 years ago

worth keeping in mind that the failed status will be manually resolved when the EDS is reset

codecov-io commented 3 years ago

Codecov Report

Merging #56 into master will decrease coverage by 0.88%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   37.54%   36.65%   -0.89%     
==========================================
  Files          29       29              
  Lines        1537     1574      +37     
==========================================
  Hits          577      577              
- Misses        886      923      +37     
  Partials       74       74
Flag Coverage Δ
unittests 36.65% <0.00%> (-0.89%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/extendeddaemonset/metrics.go 0.61% <0.00%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0fff1b...68a311b. Read the comment docs.