DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

[eds] Introduce PodCannotStart condition and canary auto-pause handling #68

Closed xornivore closed 3 years ago

xornivore commented 3 years ago

What does this PR do?

Motivation

Current limitations in support for container waiting state which are abnormal and should result in pausing canary.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Scenarios similar to tests in e2e.

codecov-io commented 3 years ago

Codecov Report

Merging #68 (635da0e) into master (c125046) will increase coverage by 0.28%. The diff coverage is 61.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   31.39%   31.68%   +0.28%     
==========================================
  Files          37       37              
  Lines        2758     2818      +60     
==========================================
+ Hits          866      893      +27     
- Misses       1809     1839      +30     
- Partials       83       86       +3     
Flag Coverage Δ
unittests 31.68% <61.61%> (+0.28%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/extendeddaemonset_types.go 100.00% <ø> (ø)
api/v1alpha1/extendeddaemonsetreplicaset_types.go 100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go 26.02% <0.00%> (-0.37%) :arrow_down:
api/v1alpha1/zz_generated.openapi.go 0.00% <0.00%> (ø)
pkg/controller/utils/pod/pod.go 21.83% <18.18%> (-6.40%) :arrow_down:
controllers/extendeddaemonset/controller.go 67.87% <60.00%> (-0.32%) :arrow_down:
...trollers/extendeddaemonsetreplicaset/controller.go 53.98% <66.66%> (+0.17%) :arrow_up:
...ers/extendeddaemonsetreplicaset/strategy/canary.go 75.39% <81.35%> (-0.43%) :arrow_down:
controllers/extendeddaemonset/utils.go 94.59% <100.00%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c125046...635da0e. Read the comment docs.