search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

Fix how EDS is using the kube-scheduler when possible #86

Closed clamoriniere closed 3 years ago

clamoriniere commented 3 years ago

What does this PR do?

Motivation

Depending of the kubernetes version (<= 1.12), the Daemonset controller is not using the kube-scheduler to schedule a Pod on a specific Node. Instead it set directly the nodeName in the pod spec. Extendeddaemonset is doing the same thing. But a bug was still setting the nodeName even if "node affinity" was used.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

clamoriniere commented 3 years ago

@celenechang thanks for the review. I have update the PR. Ready of a second review :)

codecov-io commented 3 years ago

Codecov Report

Merging #86 (077eab3) into master (79966f9) will decrease coverage by 0.17%. The diff coverage is 22.22%.

:exclamation: Current head 077eab3 differs from pull request most recent head 1776b39. Consider uploading reports for the commit 1776b39 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   46.01%   45.84%   -0.18%     
==========================================
  Files          39       39              
  Lines        2058     2068      +10     
==========================================
+ Hits          947      948       +1     
- Misses       1029     1037       +8     
- Partials       82       83       +1
Flag Coverage Δ
unittests 45.84% <22.22%> (-0.18%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/utils/pod/create.go 25.00% <0.00%> (-0.54%) :arrow_down:
pkg/controller/utils/pod/pod.go 41.58% <0.00%> (-2.63%) :arrow_down:
controllers/extendeddaemonsetreplicaset/filters.go 68.42% <40.00%> (-1.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79966f9...1776b39. Read the comment docs.