search

DataDog / extendeddaemonset

Kubernetes Extended Daemonset controller
Apache License 2.0
98 stars 13 forks source link

increase test coverage for extendeddaemonsetsettings #92

Closed celenechang closed 3 years ago

celenechang commented 3 years ago

What does this PR do?

Part of larger effort to increase test coverage, here for ExtendedDaemonsetSetting. 33.9% -> 91.5%

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

codecov-commenter commented 3 years ago

Codecov Report

Merging #92 (b8f83b0) into main (7f81393) will increase coverage by 1.87%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   49.20%   51.07%   +1.87%     
==========================================
  Files          39       39              
  Lines        2085     2085              
==========================================
+ Hits         1026     1065      +39     
+ Misses        976      936      -40     
- Partials       83       84       +1
Flag Coverage Δ
unittests 51.07% <ø> (+1.87%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/extendeddaemonsetsetting/utils.go 100.00% <0.00%> (+40.00%) :arrow_up:
controllers/extendeddaemonsetsetting/controller.go 85.96% <0.00%> (+64.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f81393...b8f83b0. Read the comment docs.