search

DataDog / fluent-plugin-datadog

Fluentd output plugin for Datadog: https://www.datadog.com
Apache License 2.0
39 stars 26 forks source link

Actually use tcp_ping_rate as the ping rate #11

Closed gregsymons closed 6 years ago

gregsymons commented 6 years ago

Motivation

Previously, the ping rate was hardcoded to once every 15 seconds, regardless of the configuration. Allowing the rate to actually be configured may help help mitigate #5. At the very least, it's truth in advertising :)

Additional Notes

I don't know if there's an undocumented internal reason for the ping rate to be hard coded. If there is, then the configuration point should probably just be deprecated and eventually removed to reduce confusion.

gregsymons commented 6 years ago

I also just realized tcp_ping_rate is not documented in the README, so if it should just be hardcoded, there's no need to deprecate it, it can just be removed.

ajacquemot commented 6 years ago

Hi @gregsymons, thanks again for your contribution, I'd not remove this parameter though, some people may be using it even though it's not (intentionally) documented.