search

DataDog / fluent-plugin-datadog

Fluentd output plugin for Datadog: https://www.datadog.com
Apache License 2.0
39 stars 26 forks source link

Sources container_id tag from kubernetes meta location #67

Closed rlafferty closed 3 months ago

rlafferty commented 4 months ago

What does this PR do?

Looks to resolve https://github.com/DataDog/fluent-plugin-datadog/issues/66

Sources the container_id tag from the default location the kubernetes input filter places the container_id attribute (kubernetes.docker_id).

Motivation

What inspired you to submit this pull request?

This will allow drillthrough from the kubernetes dashboard views in datadog (at the container level) to be able to easily find logs as its filtering/searching based on container_id. This is useful for pods that have multiple containers and you'd like it filtered for a specific container.

Additional Notes

Anything else we should know when reviewing?

rlafferty commented 3 months ago

This looks reasonable to me. Thanks for the contribution @rlafferty!

Awesome @lukesteensen - any idea if it will make it into the next release?

lukesteensen commented 3 months ago

@rlafferty Yes, this will go into the next release. I am working on getting a few things sorted out internally and then will start the release process. Hopefully later this week.