search

DataDog / glommio

Glommio is a thread-per-core crate that makes writing highly parallel asynchronous applications in a thread-per-core architecture easier for rustaceans.
Other
2.93k stars 161 forks source link

fix test for file send #627

Closed glommer closed 7 months ago

glommer commented 7 months ago

The test is broken because we can't really guarantee that the old fd will fail to open. It is entirely possible that by now, some other test (remember tests are threaded) have opened a new file for itself that ended up with the same fd as original_fd.

This test was always failing for me when I ran "cargo test" but always succeeding if I ran the test in isolation, which confirms that this is the likely cause.

glommer commented 7 months ago

@vlovich FYI

vlovich commented 7 months ago

Uggh. Terrible oversight on my part. I’m usually good about stuff like that. Thanks for tracking it down and will be more mindful going forward.

On Thu, Nov 23, 2023 at 6:32 AM Glauber Costa @.***> wrote:

Merged #627 https://github.com/DataDog/glommio/pull/627 into master.

— Reply to this email directly, view it on GitHub https://github.com/DataDog/glommio/pull/627#event-11048411654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRERZOW7EMOOR7JNQPNH3YF5NAFAVCNFSM6AAAAAA7X3Q462VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA2DQNBRGE3DKNA . You are receiving this because you were mentioned.Message ID: @.***>