search

DataDog / glommio

Glommio is a thread-per-core crate that makes writing highly parallel asynchronous applications in a thread-per-core architecture easier for rustaceans.
Other
2.93k stars 161 forks source link

Support for sending raw Ethernet frames #638

Open jamwaffles opened 4 months ago

jamwaffles commented 4 months ago

I'm looking at using glommio for its io_uring support with ethercrab which sends raw Ethernet II frames containing a custom protocol. It currently uses smol::Async with an AsFd/AsRawFd handle. Is there either

a. currently a way to use glommio to send raw Ethernet frames using this FD handle or b. something you'd consider adding?

I'd be happy to help with a PR for the latter but could use some guidance on the implementation.

If this doesn't fit the design goals of glommio I'm happy to close this issue and go my own way but I thought I'd ask here first :)

glommer commented 4 months ago

I am not very familiar with raw ethernet. From the io_uring's point of view, what is it exactly that is needed? To the best of my knowledge, io_uring itself will operate in a much higher level at the socket layer, no?

jamwaffles commented 4 months ago

Because I have a RawFd, I can use that pretty much directly with io_uring. I wrote a quick blocking test which kind of works. The bit I'm stuck on is making it async. I figured glommio might have some prior art in this area I could build on top of.

So I guess to alter my original question a bit: can I read/write a RawFd (or OwnedFd or whatever) with glommio? If not, where could I look in the codebase for inspiration? The FD I'm using just happens to be hooked up to tx/rx raw ethernet packets but from io_uring's perspective it's just data.

glommer commented 4 months ago

The way I would do this, is at the sys/uring.rs level, try our best to either reuse the existing functions (open_at and one of the read/writes should work?), and if changes are made, try to make it in a way that we don't have special reads and writes just for that.

But at the API level (src/io), then have a specialized API that deals with raw file descriptors and keep as high level, specialized, and hard to misuse as possible (I wouldn't go as far as specializing to ethernet frames, but certainly to a rawfd - but that's mostly because I don't understand ethernet well, and don't see any benefit)

I don't think this exists today, so you'd have to add it.