[APM Onboarding] Update configuration options for APM Instrumentation

liliyadd commented 6 months ago

What this PR does / why we need it:

https://github.com/DataDog/datadog-agent/pull/21673/files#diff-5d1f23f8fcec88188fb13bade49122f4cff59445aa97c64da3b84639d8355040 changed the configuration options for APM Instrumentation. This change was released as part of DCA 7.51.0.

With proposed helm-chart change, the behavior will change in two cases:

if users have apm.instrumentation.enabled=false && apm.instrumentation.enabledNamespaces=[ns_a]. Old behavior - SSI will be enabled in ns_a. New behavior - SSI is disabled.
if users have apm.instrumentation.enabled=true && apm.instrumentation.enabledNamespaces=[ns_a]. Old behavior - SSI will be enabled in the whole cluster. New behavior - SSI is enabled in ns_a only.

Without proposed change to helm-chart, customers using agent 7.51.0 will already see changed behavior - DCA will NOT instrument any application unless apm.instrumentation.enabled=true. (edited)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
[x] CHANGELOG.md has been updated
[x] Variables are documented in the README.md
[ ] For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

liliyadd commented 6 months ago

@adel121 @clamoriniere I've added the description of new config options to the changelog to address concern about customers using new agent version v7.51.0 with older chart version.

clamoriniere commented 6 months ago

/merge

dd-devflow[bot] commented 6 months ago

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 6 months ago

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 6 months ago

:x: MergeQueue

The merge has been interrupted. The current limit on the base branch 'main' is 120 minutes.

If you need support, contact us on Slack #ci-interfaces with those details!

clamoriniere commented 5 months ago

/merge

dd-devflow[bot] commented 5 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 5 months ago

:steam_locomotive: MergeQueue

This pull request was merged directly.

DataDog / helm-charts