DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
337 stars 1.01k forks source link

[APM Telemetry] Allow skipping creating Configmap with parameters needed for APM KPIs #1328

Closed liliyadd closed 4 months ago

liliyadd commented 6 months ago

What this PR does / why we need it:

Some CICD tools used by the customers always show diff for the Configmap kpi-telemetry-configmap. Adding configuration option to skip generating new install_time and install_id on DA installation/upgrade.

With default value skipKPITelemetry=false:

# Source: datadog/templates/kpi-telemetry-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: dd2-datadog-kpi-telemetry-configmap
  namespace: default
  labels:
    helm.sh/chart: 'datadog-3.57.2'
    app.kubernetes.io/name: "dd2-datadog"
    app.kubernetes.io/instance: "dd2"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: "7"
data:
  install_type: k8s_manual
  install_id: "0dd5282b-b416-46c5-9794-fe9967bdae50"
  install_time: "1708450941"

With default value skipKPITelemetry=true:

---
# Source: datadog/templates/kpi-telemetry-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: dd2-datadog-kpi-telemetry-configmap
  namespace: default
  labels:
    helm.sh/chart: 'datadog-3.57.2'
    app.kubernetes.io/name: "dd2-datadog"
    app.kubernetes.io/instance: "dd2"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: "7"
data:
  install_type: k8s_manual
  install_id: "default"
  install_time: "default"
---

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

daodennis commented 5 months ago

Very excited about this PR, thank you @liliyadd!

gaffneyd4 commented 5 months ago

In the meantime here's a kustomize patch that achieves the same behavior:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- template.yaml
patches:
- target:
    kind: ConfigMap
    name: datadog-kpi-telemetry-configmap
  patch: |
    - op: replace
      path: /data/install_id
      value: "00000000-0000-0000-0000-000000000000"
    - op: replace
      path: /data/install_time
      value: "0"
liliyadd commented 4 months ago

/merge

dd-devflow[bot] commented 4 months ago

:x: MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #devflow with those details!