missing DD_TAGS on clusterchecks runner deployment (fixes #831)
clusterChecksRunner.rbac.create=false should not create rbac resources
Special notes for your reviewer:
issue 1:
With kubeStateMetricsCore.useClusterCheckRunners=true, kubernetes_state metrics come from cluster check runner but it hasn't DD_TAGS environment variable to add global tag on theses metrics like explain in the doc
issue 2:
With clusterChecksRunner.rbac.create=false, the helm chart still deployed cluster check runner rbac (ClusterRoleBinding and ServiceAccount)
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[x] Chart Version bumped
[x] Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
[x] CHANGELOG.md has been updated
[x] Variables are documented in the README.md
[x] For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)
What this PR does / why we need it:
Fix 2 issues in cluster checks runner deployment
DD_TAGSon clusterchecks runner deployment (fixes #831)clusterChecksRunner.rbac.create=falseshould not create rbac resourcesSpecial notes for your reviewer:
issue 1: With
kubeStateMetricsCore.useClusterCheckRunners=true, kubernetes_state metrics come from cluster check runner but it hasn'tDD_TAGSenvironment variable to add global tag on theses metrics like explain in the docissue 2: With
clusterChecksRunner.rbac.create=false, the helm chart still deployed cluster check runner rbac (ClusterRoleBinding and ServiceAccount)Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)