DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
330 stars 1.01k forks source link

Synthetics Private Location - There is no way to add labels just to the pods managed by the deployment #1357

Closed krmichelos closed 3 months ago

krmichelos commented 3 months ago

Describe what happened: The only way to add labels to a pod that is controlled by the deployment currently is to set the commonLabels value. The way commonLabels is implemented it is currently included in the selector:matchLabels which makes it immutable, which requires un installing/re-installing the chart to make changes to them.

Describe what you expected: Have a podLabels value, similar to other DataDog charts, that would allow setting labels that only appear on the pods managed by the deployment.

Steps to reproduce the issue: Use the commonLabels value to add labels to the pods (and every other resource), change the value for commonLabels, and attempt an upgrade.