DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
330 stars 1.01k forks source link

Add `podLabels` value to allow setting labels that only appear on the pods managed by the deployment. #1358

Closed dmcdii closed 3 months ago

dmcdii commented 3 months ago

What this PR does / why we need it:

Add podLabels value to allow setting labels that only appear on the pods managed by the deployment. Need pod label for monitoring that value changes regularly with version upgrades. Cannot use commonLabels because they are used as match labels which are immutable.

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

dmcdii commented 3 months ago

@loutPhilipps Changed some indenting to make more readable.

dmcdii commented 3 months ago

@loutPhilipps Not sure what is up with the labeler but I did not touch anything with that. I did find at least one other pull request with same error.

loutPhilipps commented 3 months ago

Me neither :/

dmcdii commented 3 months ago

@loutPhilipps Sorry missed there were changes rebase complete.

dmcdii commented 3 months ago

@loutPhilipps Had to rebase again. I noticed it did not merge, is there something else I need to do in order to get it merged?

loutPhilipps commented 3 months ago

@loutPhilipps Had to rebase again. I noticed it did not merge, is there something else I need to do in order to get it merged?

Just merged it for you 😄