DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
343 stars 1.01k forks source link

[synthetics] Fix indent for env in private location chart #1363

Closed ruizb closed 6 months ago

ruizb commented 6 months ago

What this PR does / why we need it:

Following the changes in:

The indentation for env got broken in the deployment template. This PR fixes it.

After uncommenting the env example in values.yaml, helm template .:

Before

Error: YAML parse error on synthetics-private-location/templates/deployment.yaml: error converting YAML to JSON: yaml: line 41: did not find expected key

Use --debug flag to render out invalid YAML

After

---
# Source: synthetics-private-location/templates/service_account.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: release-name-synthetics-private-location
  labels:
    helm.sh/chart: synthetics-private-location-0.15.31
    app.kubernetes.io/name: synthetics-private-location
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.46.0"
    app.kubernetes.io/managed-by: Helm
---
# Source: synthetics-private-location/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-synthetics-private-location
...
...
...
          resources:
            {}
          env:
            - name: <ENV_VAR_NAME>
              value: <ENV_VAR_VALUE>
      volumes:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

ruizb commented 6 months ago

@loutPhilipps I updated the description accordingly 👍