search

DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
330 stars 1.01k forks source link

feat(datadog): support for registry overrrides #1376

Closed stanistan closed 2 months ago

stanistan commented 3 months ago

What this PR does / why we need it:

  1. Adds support for setting the container registry at the admissionController level, which is the default checked by the datadog-agent.

  2. ~Adds an override for autoInstrumentation (if present).~

  3. Removes the setting of DD_ADMISSION_CONTROLLER_AGENT_SIDECAR_CONTAINER_REGISTRY to registry because that behavior is implied by (1).

Which issue this PR fixes

Fixes #1078

Checklist

stanistan commented 3 months ago

@liliyadd @davidor Updated the PR... removed the setting for autoInstrumentation.containerRegistry entirely until we actually need it.

stanistan commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:x: MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #devflow with those details!