DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
330 stars 1.01k forks source link

feat(origin-detection): add unified setting #1392

Closed wdhif closed 2 months ago

wdhif commented 2 months ago

What this PR does / why we need it:

Add a new Global setting for the Origin Detection Unified setting of the Agent. This setting is a global one as it control Origin Detection behaviour for multiple Operator features (APM and DogStatsD).

Special notes for your reviewer:

Using the following chart:

➜  helm cat enabled.yaml
registry: public.ecr.aws/datadog
datadog:
  clusterName: wassim-minikube
  apiKeyExistingSecret: datadog-secret
  appKeyExistingSecret: datadog-secret
  originDetectionUnified:
    enabled: true
  kubelet:
    tlsVerify: false
    coreCheck: true
agents:
  image:
    tag: 7.54.0-rc.3-jmx
  env:
  - name: DD_TELEMETRY_ENABLED
    value: true

You should see:

➜  helm k exec -it datadog-agent-56tr4 -- agent config | grep unified
Defaulted container "agent" out of: agent, trace-agent, process-agent, init-volume (init), init-config (init)
origin_detection_unified: true

Using the following chart:

➜  helm cat enabled.yaml
registry: public.ecr.aws/datadog
datadog:
  clusterName: wassim-minikube
  apiKeyExistingSecret: datadog-secret
  appKeyExistingSecret: datadog-secret
  kubelet:
    tlsVerify: false
    coreCheck: true
agents:
  image:
    tag: 7.54.0-rc.3-jmx
  env:
  - name: DD_TELEMETRY_ENABLED
    value: true

You should see:

➜  helm k exec -it datadog-agent-jrsk5 -- agent config | grep unified
Defaulted container "agent" out of: agent, trace-agent, process-agent, init-volume (init), init-config (init)
origin_detection_unified: false

Checklist

wdhif commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

wdhif commented 2 months ago

/remove

dd-devflow[bot] commented 2 months ago

:steam_locomotive: Devflow: /remove

dd-devflow[bot] commented 2 months ago

:warning: MergeQueue

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

wdhif commented 2 months ago

Waiting for 7.54.0 release.

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 2 months ago

:x: MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #devflow with those details!

wdhif commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

wdhif commented 2 months ago

/remove

dd-devflow[bot] commented 2 months ago

:steam_locomotive: Devflow: /remove

dd-devflow[bot] commented 2 months ago

:warning: MergeQueue

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

wdhif commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

dd-devflow[bot] commented 2 months ago

:rotating_light: MergeQueue

mergequeue build completed successfully, but the github api returned an error while merging the pr. It's probably because:

Details Error: PUT https://api.github.com/repos/DataDog/helm-charts/pulls/1392/merge: 405 Pull Request is not mergeable [] FullStacktrace: activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-bfdff947-xpq9w@): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/1392/merge: 405 Pull Request is not mergeable [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

wdhif commented 2 months ago

/merge

dd-devflow[bot] commented 2 months ago

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

wdhif commented 2 months ago

/remove

dd-devflow[bot] commented 2 months ago

:steam_locomotive: Devflow: /remove

dd-devflow[bot] commented 2 months ago

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!