do not enable live process collection by default when language detection is enabled - Githubissues

DataDog / helm-charts

Helm charts for Datadog products

Apache License 2.0

343 stars 1.01k forks source link

do not enable live process collection by default when language detection is enabled #1410

Closed adel121 closed 4 months ago

adel121 commented 4 months ago

What this PR does / why we need it:

This PR removes enabling live process collection by default when language detection is enabled.

Which issue this PR fixes

Fixes the issue of enabling live process detection by default for APM SSI users.

Special notes for your reviewer:

A fix was implemented in the agent to allow language detection to work in case live process collection is not enabled.
The initial PR that activated live process collection by default when language detection is enabled can be found here.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
[x] CHANGELOG.md has been updated
[x] Variables are documented in the README.md
[x] For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

adel121 commented 4 months ago

quick remarks could you link the PR that have introduced the activation by default in the PR description.

Also, where do we activate the langage-detection remote endpoint in the process-agent? is it one by default?

for the second part I found my answer:

https://github.com/DataDog/helm-charts/blob/b3a6c4d06e1441b813115b9d8a0e741613542202/charts/datadog/templates/_components-common-env.yaml#L4-L7

For your first point, I updated the PR description.