DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
343 stars 1.01k forks source link

APM instrumentation increase default memory limit #1520

Closed Kyle-Verhoog closed 3 weeks ago

Kyle-Verhoog commented 3 weeks ago

What this PR does / why we need it:

The default chosen (20MB) in 7.57.0 of the agent is too low which results in OOMKills for some of the APM library InitContainers. This is likely due to a regression in the size of the APM libraries. Once a fix is merged upstream in the Agent we should add a version gate on this setting so it only applies to the versions affected.

64Mi was successfully tested in a default GKE cluster and a local minikube. Since we'd like to mitigate the issue immediately 128Mi should be more than safe enough given that 64Mi worked to protect against any further regressions in the library InitContainers.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

tbavelier commented 3 weeks ago

Fixed conflicts in https://github.com/DataDog/helm-charts/pull/1524, so closing this one for now