search

DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
341 stars 1.01k forks source link

Datadog Helm Chart To Use FQDN For Default API URLs #511

Open mattjamesaus opened 2 years ago

mattjamesaus commented 2 years ago

Describe what happened: The datadog agent by default uses datadoghq.com as a default value for datadog.site in the helm chart, in a standard k8 environment with several search domains this puts extra pressure on the coreDNS pods to do the extra resolution of what will inevitably fail i.e 

orchestrator.datadoghq.com.monitoring.svc.cluster.local.
orchestrator.datadoghq.com.svc.cluster.local.
orchestrator.datadoghq.com.ec2.internal.

Instead of the site.default was set to datadoghq.com. (see the trailing period) it would mean its fully qualified and not use the additional search domains. This will result in faster DNS resolution, better performance and less strain on coreDNS.

Describe what you expected: Datadog should use FQDN as the default for the cluster.

Steps to reproduce the issue: Use the default helm chart

Additional environment details (Operating System, Cloud provider, etc): EKS

L3n41c commented 2 years ago

Hello @mattjamesaus, Thanks for reaching out !

Adding a trailing dot as you suggests is perfectly valid from a RFC point of view and it would indeed make the hostname be considered as a FQDN and it would indeed avoid the useless DNS queries.

Unfortunately, we had bad experiences in the past where the trailing dot was causing some issues in cloud provider loadbalancers. Because of those issues, we had to remove the trailing dot. That’s why we are discouraging its use and we are not putting it by default.