DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
339 stars 1.01k forks source link

When `targetSystem=windows`, Helm chart should not attempt to deploy `cluster-agent` #574

Open Jberlinsky opened 2 years ago

Jberlinsky commented 2 years ago

Describe what happened:

When executing a Helm deployment in line with the documentation found throughout Datadog's documentation and UI (i.e. helm install datadog datadog/datadog -f values.yaml --targetSystem=windows ..., the Helm chart attempts to deploy cluster-agent, which can "only be deployed on Linux nodes".

Describe what you expected:

Helm should Do The Right Thing (TM) and not attempt to deploy cluster-agent if targetSystem==windows

Steps to reproduce the issue:

See above

Additional environment details (Operating System, Cloud provider, etc):

Windows nodes in GKE cluster

clamoriniere commented 2 years ago

Hi @Jberlinsky

Thanks for reporting this issue. have you followed the windows deployment documentation and set the parameter existingClusterAgent.join:true

The cluster-agent is a key component for the Agent deployment on Kubernetes (windows and linux). We recommend to deploy first the helm chart to target the linux Node and deploy the cluster-agent, Then deploy the a second instance of the datadog chart to target the windows nodes.

with at least the following option set

targetSystem: windows

existingClusterAgent:
  join: true
  serviceName: "<EXISTING_DCA_SERVICE_NAME>" # from the other datadog helm chart release
  tokenSecretName: "<EXISTING_DCA_SECRET_NAME>" # from the other datadog helm chart release

# Disabled datadogMetrics deployment since it should have been already deployed with the other chart release.
datadog-crds:
  crds:
    datadogMetrics: false

# Disable kube-state-metrics deployment
datadog:
  kubeStateMetricsEnabled: false]

please let us know if if solve the deployment problem.