search

DataDog / integrations-core

Core integrations of the Datadog Agent
BSD 3-Clause "New" or "Revised" License
879 stars 1.37k forks source link

Support new cockroachdb metrics for v24.1. #17600

Open jmcarp opened 1 month ago

jmcarp commented 1 month ago

Now that cockroachdb v24.1 is generally available, Datadog should support metrics added in the latest release. I believe the new metrics should be added to the metrics map and metadata.csv. I would be happy to send a PR adding the new metrics, unless it's easier for the Datadog team (cc @FlorentClarret) to do it.

I would also be curious to hear what kind of process the Datadog team would support for regular updates. Do you all have some automation to update the metrics mapping and metadata? If not, would you accept a PR adding that automation?

cc @sudomateo

FlorentClarret commented 1 month ago

Hello @jmcarp 👋

Thanks for opening this issue! I let the team in charge of the integration know about this, they will reach out soon.

sudomateo commented 1 month ago

Thank you! Having a regular process to update the integration metrics would be a fantastic experience. CockroachDB already generates its metrics for its documentation in this https://github.com/cockroachdb/cockroach/blob/master/docs/generated/metrics/metrics.html file. Perhaps we can use that.