DataDog / integrations-core

Core integrations of the Datadog Agent
BSD 3-Clause "New" or "Revised" License
937 stars 1.41k forks source link

Update vsphere_overview.json #18684

Closed Faysal1357 closed 1 month ago

Faysal1357 commented 1 month ago

What does this PR do?

The out of the box dashboard does not show any event when template variable $vcenter_server and $vcenter_datacenter is used

Motivation

https://datadog.zendesk.com/agent/tickets/1862372 The code suggest $vcenter_server.value and $vcenter_datacenter.value is being used currently in for vSphere events widget defination. However, when we select a value for template variable $vcenter_server and $vcenter_datacenter, the widget shows no result. This is because the widget query is then scoped to source:vsphere $vcenter_server.value $vcenter_datacenter.value. This works when the query is changed to "source:vsphere $vcenter_server $vsphere_datacenter". The events that are ingested by Vsphere integration has a no tag named vcenter_datacenter but has vsphere_datacenter.

Additional Notes

We can reproduce the error in demo org here https://app.datadoghq.com/screen/integration/249/vmware-vsphere---overview?_ga=2.36746720.1513437160.1727045382-1943259521.1724729273&_gl=1%2A18s4xm3%2A_gcl_au%2AODM5MTQzNTQ1LjE3MjUyMzYxMjk.%2A_ga%2AMTk0MzI1OTUyMS4xNzI0NzI5Mjcz%2A_ga_KN80RDFSQK%2AMTcyNzM5Nzk4Ni4xMTguMS4xNzI3NDAyOTA1LjAuMC4yNzA1OTkyNTQ.%2A_fplc%2AUHZGTTJDR21kSGhLTGI5S0VWWm5qS3hXYk1PUEhtZFQ5cGRmaGhtQjA5TFNHVGk0MzlOZnE4VHlnVTU0bVJQb3IlMkZ2R3hqZ0JDbmNsOHRPOUp1MzNGS0tET2I3T1VyOEcwQXNvRld1cElpaDNWRE5qSlhHNkFqNVRHS204ZlElM0QlM0Q.&fromUser=false&refresh_mode=sliding&from_ts=1727399315230&to_ts=1727402915230&live=true

Review checklist (to be filled by reviewers)

Faysal1357 commented 1 month ago

Here is the support notebook that we may use to verify https://app.datadoghq.com/notebook/9920192/sayed-sep-27-2024-13-13?range=172800000&tpl_var_vcenter_server%5B0%5D=vcsa-nyc-01&tpl_var_vsphere_datacenter%5B0%5D=us-nyc-prod-01&start=1727234080463&live=true

Faysal1357 commented 1 month ago

Thank you everyone :)