search

DataDog / integrations-core

Core integrations of the Datadog Agent
BSD 3-Clause "New" or "Revised" License
937 stars 1.41k forks source link

Sy/elastic sc tags #18687

Closed steveny91 closed 1 month ago

steveny91 commented 1 month ago

What does this PR do?

The host tag should have been reserved ~since it's observed to create new hosts in the infra list~ (doesn't happen with just service checks). This change hopes to change that by removing it from the service checks. This will be opt in as to not break any backwards compatibility.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.55%. Comparing base (d837ba9) to head (fbaff0a). Report is 20 commits behind head on master.

Additional details and impacted files | [Flag](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [activemq](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [cassandra](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [elastic](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `93.41% <100.00%> (+0.08%)` | :arrow_up: | | [hive](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [hivemq](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [ignite](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [jboss_wildfly](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [kafka](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [presto](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [solr](https://app.codecov.io/gh/DataDog/integrations-core/pull/18687/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more.