DataDog / integrations-core

Core integrations of the Datadog Agent
BSD 3-Clause "New" or "Revised" License
937 stars 1.41k forks source link

Change read_time_pct / write_time_pct description because they are kept for backward compatibility. #18980

Open masafm opened 1 week ago

masafm commented 1 week ago

What does this PR do?

Change read_time_pct / write_time_pct description because they are kept for backward compatibility as described in the code comment.

Motivation

Since this file serves as the basis for customer-facing documentation, any inaccuracies could lead to confusion. In case 1901092, the customer inquired if the values for read_time_pct and write_time_pct might be incorrect.

Review checklist (to be filled by reviewers)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.76%. Comparing base (33de32f) to head (1bbe50c).

Additional details and impacted files | [Flag](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [activemq](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [cassandra](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [disk](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `90.86% <ø> (+1.42%)` | :arrow_up: | | [hive](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [hivemq](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [hudi](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [ignite](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [jboss_wildfly](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [kafka](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [presto](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [solr](https://app.codecov.io/gh/DataDog/integrations-core/pull/18980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more.