search

DataDog / integrations-core

Core integrations of the Datadog Agent
BSD 3-Clause "New" or "Revised" License
935 stars 1.4k forks source link

Add support for mongo 4.4 #9605

Closed jefimm closed 3 years ago

jefimm commented 3 years ago

Current mongo integration is bundling pymongo 3.9 - mongo 4.4 require pymongo 3.11

FlorianVeaux commented 3 years ago

Hey @jefimm I'm curious if you see any agent issue with pymongo 3.9 and mongo 4.4, Mongo does a pretty good job at backward compatibility usually and I can't see any impact on my end.

jefimm commented 3 years ago

I have tried the current agent and it did not work with mongo 4.4. I have upgraded the pymongo and installed ca-certificates into the agent (running on kubernetes) and now it is able to connect.

As a general note the mongo integration seems to be neglected - I'm struggling to make it work as even simple count queries return 0 The mongo atlas preferred method of connecting like mongodb+srv://XXX.mongodb.net is not supported well (possible to do with "server" parameter but designated as deprecated)

FlorianVeaux commented 3 years ago

I have tried the current agent and it did not work with mongo 4.4

Would you mind providing an error log so we can investigate? We're still gonna bump pymongo because it's always a good thing to do, but I can't tell what's wrong from your issue.

As a general note the mongo integration seems to be neglected

If you have other issues please detail them, the mongo integration is actively maintained.

I'm struggling to make it work as even simple count queries return 0

Please open a support ticket if you need assistance for how to configure the integration.

The mongo atlas preferred method of connecting like mongodb+srv://XXX.mongodb.net is not supported well

As you can see on the docs here and in the example conf.yaml file here monitoring a mongo cluster is performed by connecting to each node independently. Most of the monitoring commands have to be performed "locally". That's why the MongoDB integration requires you to configure one agent (or one check instance) for each node in your cluster, and that's why mongodb+srv is not really supported.

jefimm commented 3 years ago

Support ticket was opened (#517393) I'm trying to configure clustercheck to run several queries on mongo atlas cluster and make the result a metric. This case is different from monitoring nodes in self-managed deployment.

FlorianVeaux commented 3 years ago

We just upgraded pymongo: https://github.com/DataDog/integrations-core/pull/9608/s