CloudAEye Integration with Datadog (ECOINT-19)

DataDog / integrations-extras

Community developed integrations and plugins for the Datadog Agent.

BSD 3-Clause "New" or "Revised" License

252 stars 734 forks source link

CloudAEye Integration with Datadog (ECOINT-19) #2386

Open ankit-cloudaeye opened 4 months ago

ankit-cloudaeye commented 4 months ago

What does this PR do?

This PR is to add CloudAEye Integration plugin in Datadog. This is for the tile-only-listing API-based integration.

Motivation

We want to integrate our services with datadog.

Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
[ ] If this PR includes a log pipeline, please add a description describing the remappers and processors.

drichards-87 commented 4 months ago

Created Jira card for Docs Team editorial review.

emarsha94 commented 3 months ago

👋 Quick heads up that I will be out of office next week so there may be a delay in the review from my end until July 8th. With that said, other teams will continue to review the PR. Thanks in advance for your patience!

emarsha94 commented 2 months ago

Hi @bhavyalatha26 - Thank you for making the changes! Your PR is missing the codeowners file. Could you please add the codeowners file to the PR? To edit via web ui:

Go to your forked repository > .github > CODEOWNERS file
Edit the file by clicking the pencil icon in the top right
Add your integration name and github handle in alphabetical order
Click Commit changes directly to the master branch

bhavyalatha26 commented 2 months ago

Hi @bhavyalatha26 - Thank you for making the changes! Your PR is missing the codeowners file. Could you please add the codeowners file to the PR? To edit via web ui:
1. Go to your forked repository > .github > CODEOWNERS file

2. Edit the file by clicking the pencil icon in the top right

3. Add your integration name and github handle in alphabetical order

4. Click Commit changes directly to the master branch

Hi @emarsha94,

Thanks for the details. Had a look at the codeowners file, can you please confirm if this is how I need to add an entry in the Community Partners section:

/cloudaeye_integration/                  @CloudAEye info@cloudaeye.com @DataDog/integration-extras

Regards, Bhavya

bhavyalatha26 commented 2 months ago

Bumping the requested changes from before then good to approve

approved the changes. Thanks !

bhavyalatha26 commented 2 months ago

Hi team , we have committed all your suggestion and also updated the README and cloudaeye/assets/dashboards/CloudAEye_overview.json as requested

JoshPatel13 commented 1 week ago

Hi, could you click update branch on your PR to see if that resolves the validation issues?

JoshPatel13 commented 1 week ago

Also, there needs to be a field added called configuration here :) :

  "assets": {
    "integration": {
      "source_type_name": "source_type_name",
      "configuration": {},

bhavyalatha26 commented 1 week ago

Hi, could you click update branch on your PR to see if that resolves the validation issues?

Done

bhavyalatha26 commented 1 week ago

Also, there needs to be a field added called configuration here :) :
  "assets": {
    "integration": {
      "source_type_name": "source_type_name",
      "configuration": {},

Ok, can you please create a commit suggestion for the same, so that we can approve directly. TIA