search

DataDog / integrations-extras

Community developed integrations and plugins for the Datadog Agent.
BSD 3-Clause "New" or "Revised" License
244 stars 701 forks source link

Redis enterprise #2433

Open j8-redis opened 2 weeks ago

j8-redis commented 2 weeks ago

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

Additional Notes

Anything else we should know when reviewing?

j8-redis commented 2 days ago

Emily

Based on your comment I expect this to be the correct URL:

https://raw.githubusercontent.com/DataDog/integrations-extras/master/redis_enterprise/assets/logos/logo.svg

Is it?

Thanks again!

John

On Mon, Jul 15, 2024 at 4:38 PM emarsha94 @.***> wrote:

@.**** requested changes on this pull request.

In redis_enterprise/assets/dashboards/redis_enterprise_overview.json https://github.com/DataDog/integrations-extras/pull/2433#discussion_r1678362507 :

@@ -6,7 +6,7 @@ "id": 325090501093728, "definition": { "title": "About Redis Enterprise",

This image will not appear. This will need to be the raw image like the original link you provided. To get this, you can go to the image in your integration folder in the ints-extras repo, open image in a new tab, and copy the link. Ensure it has: raw.githubusercontent in it

— Reply to this email directly, view it on GitHub https://github.com/DataDog/integrations-extras/pull/2433#pullrequestreview-2178602904, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5B6FMH6QJGDIOJ6ILKI62DZMQXKXAVCNFSM6AAAAABKKB5V66VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZYGYYDEOJQGQ . You are receiving this because you authored the thread.Message ID: @.***>

Disclaimer

The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website.

emarsha94 commented 2 days ago

https://raw.githubusercontent.com/DataDog/integrations-extras/master/redis_enterprise/assets/logos/logo.svg

Hi John, that is the correct url. A quick way to test this is to go to your dashboard widget and replace the logo url with the new one. If the image/logo shows then it's correct, if you just see white then it's the wrong url. Cheers!