search

DataDog / java-dogstatsd-client

Java statsd client library
MIT License
176 stars 101 forks source link

Using micrometer-registry-statsd doesn't report TimeUnit to DataDog #145

Open ayeletmorris opened 3 years ago

ayeletmorris commented 3 years ago

Hi, I'm using micrometer-registry-statsd with @timed to report time series data to DataDog, and all of my metrics have "none" in the time unit section in the metrics summary page.

I saw that in the StatsdMeterRegistry class the "getBaseTimeUnit" method returns Milliseconds, and when I updated all my metrics manually (this took forever :) ) to milliseconds, the data in my graphs makes sense.

Why doesn't it show this reported time unit in the dataDog metric? Why isn't is sent?

BTW - I asked this question in micrometer gitHub and got this answer: micrometer-metrics/micrometer#2528 They say that in their implementation (DatadogMeterRegistry) they do send the time unit in the metric metadata, and that the issue here is in the dogStatsD client.

Thanks for your help :)

truthbk commented 3 years ago

@ayeletmorris I'm not sure how we can help you, micrometer-registry-statsd does not use this project, java-dogstatsd-client, internally. Perhaps I'm misunderstanding your question?