DataDog / kvexpress

## Auto-archived due to inactivity. ## Go program to move data in and out of Consul's KV store.
Apache License 2.0
128 stars 13 forks source link

kvexpress can't currently make directories #86

Closed darron closed 8 years ago

darron commented 8 years ago

So if you tell it to place it inside a directory that doesn't exist it:

  1. Logs a lot.
  2. Panics.

We should probably create the directory.

It would likely need to happen here:

https://github.com/DataDog/kvexpress/blob/28410237bf563a3e9195b7e6c49f1ca43f15bf90/commands/files.go#L51-L56

darron commented 8 years ago

I think there's a couple things that have to be done here:

That may have been the problem we were seeing with using up all of the file descriptors - which caused too many logs and ended up doing bad things to a test environment.

darron commented 8 years ago

There doesn't appear to be a way to close the Consul connection - there's nothing in the API.

Am going to close this since we've corrected that particular issue.